MINOR: Cleanup ControllerContext and StateChangeLogger#18588
Merged
ijuma merged 1 commit intoapache:trunkfrom Jan 22, 2025
Merged
Conversation
github-actions
bot
added
triage
frankvicky
changed the title
Member
|
we can remove the ControllerContext.scala after https://issues.apache.org/jira/browse/KAFKA-18427 gets resolved |
frankvicky
force-pushed
the
clean-up-controller-context-and-state-change-logger
branch
2 times, most recently
from
8daee0c to
2cad365
Compare
Member
|
KAFKA-18427 has been resolved. |
frankvicky
force-pushed
the
clean-up-controller-context-and-state-change-logger
branch
from
2cad365 to
3da4236
Compare
Contributor
Author
|
Hi @ijuma |
ijuma
reviewed
Jan 21, 2025
| createTopicWithAssignment(topic2, partitionReplicaAssignment = topic2Assignment.map { case (k, v) => k -> v.replicas }) | ||
| createTopicWithAssignment(topic3, partitionReplicaAssignment = topic3Assignment.map { case (k, v) => k -> v.replicas }) | ||
| createTopicWithAssignment(topic4, partitionReplicaAssignment = topic4Assignment.map { case (k, v) => k -> v.replicas }) | ||
| createTopicWithAssignment(topic1, partitionReplicaAssignment = topic1Assignment.map { case (k, v) => k -> v.head }) |
Member
There was a problem hiding this comment.
Looks like we always only use the head of the list - can we remove the List wrapper altogether?
frankvicky
force-pushed
the
clean-up-controller-context-and-state-change-logger
branch
from
3da4236 to
e965a8e
Compare
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
These methods were previously invoked by ZK components, but we have just removed them. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
These methods were previously invoked by ZK components, but we have just removed them. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
These methods were previously invoked by ZK components, but we have just removed them. Reviewers: Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods were previously invoked by ZK components, but we have just removed them.
Committer Checklist (excluded from commit message)